Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 )
Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command ...................................................................... Patch Set 11: (3 comments) Applied updated. http://gerrit.cloudera.org:8080/#/c/8928/10/fe/src/main/java/org/apache/impala/analysis/AlterTableSetRowFormatStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSetRowFormatStmt.java: http://gerrit.cloudera.org:8080/#/c/8928/10/fe/src/main/java/org/apache/impala/analysis/AlterTableSetRowFormatStmt.java@66 PS10, Line 66: "supported on HDFS tables. Conflicting table: %1$s", tbl.getFullName())); > Remove extra space before "Conflicting". Done http://gerrit.cloudera.org:8080/#/c/8928/10/fe/src/main/java/org/apache/impala/analysis/AlterTableSetRowFormatStmt.java@85 PS10, Line 85: "only supported on TEXT or SEQUENCE file formats. Conflicting " + > Remove extra space before "Conflicting". Done http://gerrit.cloudera.org:8080/#/c/8928/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/8928/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@488 PS10, Line 488: AnalysisError("alter table functional.alltypesmixedformat partition(year=2009) " + > I mean testing the PARTITION clause. The test should select a subset of par Done -- To view, visit http://gerrit.cloudera.org:8080/8928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I96e347463504915a6f33932552e4d1f61e9b1154 Gerrit-Change-Number: 8928 Gerrit-PatchSet: 11 Gerrit-Owner: Adam Holley <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Comment-Date: Sun, 14 Jan 2018 05:35:32 +0000 Gerrit-HasComments: Yes
