Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8949 )
Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/8949/2/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/8949/2/be/src/service/impala-server.h@978 PS2, Line 978: escriptorMap known_b > UpdateCatalogVersionMetrics() Changed the name of function. http://gerrit.cloudera.org:8080/#/c/8949/2/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/8949/2/be/src/service/impala-server.cc@1325 PS2, Line 1325: ImpaladMetrics::CATALOG_VERSION->set_value(catalog_version); > Maybe my comment was not clear. What I meant is that you should also expose I have made changes to expose catalog_topic version along with catalog_service_id http://gerrit.cloudera.org:8080/#/c/8949/2/be/src/util/impalad-metrics.h File be/src/util/impalad-metrics.h: http://gerrit.cloudera.org:8080/#/c/8949/2/be/src/util/impalad-metrics.h@113 PS2, Line 113: CATALOG_VERSION; > CATALOG_VERSION, CATALOG_TOPIC_VERSION, CATALOG_SERVICE_ID Done http://gerrit.cloudera.org:8080/#/c/8949/2/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/8949/2/common/thrift/metrics.json@233 PS2, Line 233: The version of catalog which is currently with impal > Maybe "Version of the Impalad catalog." Changed -- To view, visit http://gerrit.cloudera.org:8080/8949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97 Gerrit-Change-Number: 8949 Gerrit-PatchSet: 3 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-Comment-Date: Thu, 18 Jan 2018 19:22:20 +0000 Gerrit-HasComments: Yes
