Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8949 )
Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. ...................................................................... Patch Set 5: (8 comments) A few renames on the metric labels. http://gerrit.cloudera.org:8080/#/c/8949/5/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/8949/5/be/src/service/impala-server.cc@1322 PS5, Line 1322: /// Update the metrics to store the current version of catalog, catalog topic version, : /// and catalog service id which are used by impalad. remove comment. You already have the same comment in .h file. http://gerrit.cloudera.org:8080/#/c/8949/5/be/src/util/impalad-metrics.h File be/src/util/impalad-metrics.h: http://gerrit.cloudera.org:8080/#/c/8949/5/be/src/util/impalad-metrics.h@123 PS5, Line 123: nit: remove extra line http://gerrit.cloudera.org:8080/#/c/8949/5/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/8949/5/common/thrift/metrics.json@233 PS5, Line 233: Version of the catalog which is currently with impalad "Catalog topic update version." http://gerrit.cloudera.org:8080/#/c/8949/5/common/thrift/metrics.json@237 PS5, Line 237: Catalog version Impalad "Catalog topic update version" http://gerrit.cloudera.org:8080/#/c/8949/5/common/thrift/metrics.json@243 PS5, Line 243: ersion of the catalog topic which is currently with impalad. "Statestore topic update version." http://gerrit.cloudera.org:8080/#/c/8949/5/common/thrift/metrics.json@247 PS5, Line 247: Catalog topic Impalad "Statestore topic update version" http://gerrit.cloudera.org:8080/#/c/8949/5/common/thrift/metrics.json@253 PS5, Line 253: Service id of catalog which is currently with impalad. "Catalog service id" http://gerrit.cloudera.org:8080/#/c/8949/5/common/thrift/metrics.json@257 PS5, Line 257: Catalog ServiceID Impalad "Catalog service id" -- To view, visit http://gerrit.cloudera.org:8080/8949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97 Gerrit-Change-Number: 8949 Gerrit-PatchSet: 5 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Pranay Singh Gerrit-Comment-Date: Fri, 19 Jan 2018 05:40:57 +0000 Gerrit-HasComments: Yes
