Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8949 )
Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. ...................................................................... Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/8949/5/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/8949/5/be/src/service/impala-server.cc@1322 PS5, Line 1322: void ImpalaServer::CatalogUpdateVersionInfo::UpdateCatalogVersionMetrics() : { > remove comment. You already have the same comment in .h file. Done http://gerrit.cloudera.org:8080/#/c/8949/5/be/src/util/impalad-metrics.h File be/src/util/impalad-metrics.h: http://gerrit.cloudera.org:8080/#/c/8949/5/be/src/util/impalad-metrics.h@123 PS5, Line 123: > nit: remove extra line Done http://gerrit.cloudera.org:8080/#/c/8949/5/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/8949/5/common/thrift/metrics.json@233 PS5, Line 233: Catalog topic update version.", > "Catalog topic update version." Done http://gerrit.cloudera.org:8080/#/c/8949/5/common/thrift/metrics.json@237 PS5, Line 237: Catalog topic update ve > "Catalog topic update version" Done http://gerrit.cloudera.org:8080/#/c/8949/5/common/thrift/metrics.json@243 PS5, Line 243: tatestore topic update version.", > "Statestore topic update version." Done http://gerrit.cloudera.org:8080/#/c/8949/5/common/thrift/metrics.json@247 PS5, Line 247: Statestore topic upda > "Statestore topic update version" Done http://gerrit.cloudera.org:8080/#/c/8949/5/common/thrift/metrics.json@253 PS5, Line 253: Catalog service id.", > "Catalog service id" Done -- To view, visit http://gerrit.cloudera.org:8080/8949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97 Gerrit-Change-Number: 8949 Gerrit-PatchSet: 6 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Pranay Singh Gerrit-Comment-Date: Fri, 19 Jan 2018 23:26:34 +0000 Gerrit-HasComments: Yes
