Hello Michael Brown, Philip Zeyliger, David Knupp,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9074
to look at the new patch set (#2).
Change subject: IMPALA-6420: Fix TestCharFormats for local filesystem tests
......................................................................
IMPALA-6420: Fix TestCharFormats for local filesystem tests
Tl;dr - running tests was covering up a bug in the tests,
or alternatively, not running tests exposes a bug.
Local tests were failing because we failed to prepend
the local filesystem prefix. This was covered up because
the snapshot creation job runs tests, which actually creates
these tables in the metastore. When running local filesystem
tests with a snapshot, the table creation never runs because
the snapshot import converts hdfs:// locations into local
file locations. The problematic CREATE TABLE x IF NOT EXISTS
then never get run, hiding the problem.
Testing: With a local filesystem install, in Impala shell:
drop table functional_parquet.chars_formats
and then:
tests/run-tests.py query_test/test_chars.py -k char_format
Change-Id: I916b5566a3c5a83185e502b814ad43b5af14e87f
---
M tests/query_test/test_chars.py
1 file changed, 9 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/9074/2
--
To view, visit http://gerrit.cloudera.org:8080/9074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I916b5566a3c5a83185e502b814ad43b5af14e87f
Gerrit-Change-Number: 9074
Gerrit-PatchSet: 2
Gerrit-Owner: Zach Amsden <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
