Impala Public Jenkins has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/9074 )
Change subject: IMPALA-6420: Fix TestCharFormats for local filesystem tests
......................................................................
IMPALA-6420: Fix TestCharFormats for local filesystem tests
Tl;dr - running tests was covering up a bug in the tests,
or alternatively, not running tests exposes a bug.
Local tests were failing because we failed to prepend
the local filesystem prefix. This was covered up because
the snapshot creation job runs tests, which actually creates
these tables in the metastore. When running local filesystem
tests with a snapshot, the table creation never runs because
the snapshot import converts hdfs:// locations into local
file locations. The problematic CREATE TABLE x IF NOT EXISTS
then never get run, hiding the problem.
Testing: With a local filesystem install, in Impala shell:
drop table functional_parquet.chars_formats
and then:
tests/run-tests.py query_test/test_chars.py -k char_format
Change-Id: I916b5566a3c5a83185e502b814ad43b5af14e87f
Reviewed-on: http://gerrit.cloudera.org:8080/9074
Reviewed-by: Alex Behm <[email protected]>
Tested-by: Impala Public Jenkins
---
M tests/query_test/test_chars.py
1 file changed, 9 insertions(+), 8 deletions(-)
Approvals:
Alex Behm: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I916b5566a3c5a83185e502b814ad43b5af14e87f
Gerrit-Change-Number: 9074
Gerrit-PatchSet: 3
Gerrit-Owner: Zach Amsden <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Zach Amsden <[email protected]>
