Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9074 )
Change subject: IMPALA-6420: Fix TestCharFormats for local filesystem tests ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9074/2/tests/query_test/test_chars.py File tests/query_test/test_chars.py: http://gerrit.cloudera.org:8080/#/c/9074/2/tests/query_test/test_chars.py@93 PS2, Line 93: def __create_char_tables(self): > Can we rework this to use unique_database instead? These tables should not I think since this relies on an external file populated in an earlier data loading phase, that for now, we need an absolute path instead of a unique one. Very open to suggestions. If we could move the data load into this test, we should be able to fix that and just use a unique database, but this is very awkward with the existing testdata/workloads, testdata/datasets, tests separation. The dataset involved here is quite small, so it is doable, but if we are going to attempt that, we should probably approach it in terms of a more unified strategy instead of just throwing datasets directly into the tests. -- To view, visit http://gerrit.cloudera.org:8080/9074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I916b5566a3c5a83185e502b814ad43b5af14e87f Gerrit-Change-Number: 9074 Gerrit-PatchSet: 2 Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-Comment-Date: Fri, 19 Jan 2018 20:02:48 +0000 Gerrit-HasComments: Yes
