Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8997 )
Change subject: IMPALA-6338: Fix flaky test_profile_fragment_instances ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8997/2/be/src/runtime/coordinator-backend-state.h File be/src/runtime/coordinator-backend-state.h: http://gerrit.cloudera.org:8080/#/c/8997/2/be/src/runtime/coordinator-backend-state.h@206 PS2, Line 206: either because the client called Cancel() or because the coordinator : /// initiated cancel because all the results were already returned > It could also be because another backend hit an error. Done http://gerrit.cloudera.org:8080/#/c/8997/2/be/src/runtime/coordinator-backend-state.h@243 PS2, Line 243: other than cancel > We're making a base assumption that a CANCELLED status is only obtained as I don't think that there are any situations in which a fragment instance would try to cancel the query without it being the result of some error, and of course if the coordinator sees an error it will cancel the query. I did some grepping around to confirm this, but I'll get someone with more authority to chime in. http://gerrit.cloudera.org:8080/#/c/8997/2/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/8997/2/be/src/runtime/coordinator.cc@926 PS2, Line 926: // If the query was cancelled by the user, don't process the update. : if (query_status_.IsCancelled()) return Status::OK(); > Shouldn't we tell the backend to cancel itself if the query was cancelled b Yes, we're relying on Cancel() having already sent cancels to all of the backends. -- To view, visit http://gerrit.cloudera.org:8080/8997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77773a1e3c62952003f37f88fe2b662bb11889ed Gerrit-Change-Number: 8997 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Tue, 23 Jan 2018 21:44:32 +0000 Gerrit-HasComments: Yes
