Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8997 )
Change subject: IMPALA-6338: Fix flaky test_profile_fragment_instances ...................................................................... Patch Set 3: Code-Review+1 (1 comment) The change LGTM. The only other thing I want to bring up is that we're preferring a full profile over a quick teardown of a query. From a correctness point of view, that's sound. However, that may regress short queries in terms of total query time taken. But that's probably a topic for a much larger discussion that can be addressed as part of IMPALA-2990. Since this change changes the lifecycle of a query a bit, it would be better if someone else had a look too. http://gerrit.cloudera.org:8080/#/c/8997/3/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/8997/3/be/src/runtime/coordinator.cc@462 PS3, Line 462: nit: Not your change, but we can get rid of this bad indent. -- To view, visit http://gerrit.cloudera.org:8080/8997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77773a1e3c62952003f37f88fe2b662bb11889ed Gerrit-Change-Number: 8997 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Thu, 25 Jan 2018 23:41:03 +0000 Gerrit-HasComments: Yes
