Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8997 )
Change subject: IMPALA-6338: Fix flaky test_profile_fragment_instances ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8997/5/be/src/runtime/coordinator-backend-state.h File be/src/runtime/coordinator-backend-state.h: http://gerrit.cloudera.org:8080/#/c/8997/5/be/src/runtime/coordinator-backend-state.h@223 PS5, Line 223: /// initiated cancel because all the results were already returned or an error was hit. Are we assuming that status_ == CANCELLED implies that the cancellation was initiated by the coordinator? We should document that explicitly if so, and maybe also document Status::CANCELLED. Would some of this logic be broken if one of the fragments failed without being cancelled and returned status CANCELLED? I believe that this shouldn't currently happen but it isn't currently documented. Weirdly we use CANCELLED internally in some subsystems but if it leaks out to the fragment status it's a bug. We should probably switch to a different status for those use cases. -- To view, visit http://gerrit.cloudera.org:8080/8997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77773a1e3c62952003f37f88fe2b662bb11889ed Gerrit-Change-Number: 8997 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 01 Feb 2018 20:00:56 +0000 Gerrit-HasComments: Yes
