Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9124 )
Change subject: IMPALA-6440: Backwards compatibility for HBase metadata ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/9124/1/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java File fe/src/main/java/org/apache/impala/catalog/HBaseTable.java: http://gerrit.cloudera.org:8080/#/c/9124/1/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java@117 PS1, Line 117: for backwards compatibility with the original spec. > Actually, I would mention here which was the latest version to support this Done http://gerrit.cloudera.org:8080/#/c/9124/1/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java@449 PS1, Line 449: try : // the original table name, and if that fails, try looking for the : // original table name property in SERDEPROPERTIES. > I am a bit confused with the terminology. Is HBaseSerDe.HBASE_TABLE_NAME th The original table name, and the name that used to be stored in SERDEPROPERTIES is "hbase.table.name". HBaseSerDe.HBASE_TABLE_NAME is the new table name, which varies depending on which version of HBase we link with (and varies even with versions due to late breaking changes). http://gerrit.cloudera.org:8080/#/c/9124/1/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java@452 PS1, Line 452: look for > nit: we're not looking for it, we simply construct it, no? Done -- To view, visit http://gerrit.cloudera.org:8080/9124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7c5b62f38be275762771ecf39cf898f06f8138b Gerrit-Change-Number: 9124 Gerrit-PatchSet: 1 Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-Comment-Date: Wed, 24 Jan 2018 23:29:59 +0000 Gerrit-HasComments: Yes
