Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9124 )
Change subject: IMPALA-6440: Backwards compatibility for HBase metadata ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/9124/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9124/1//COMMIT_MSG@9 PS1, Line 9: Upstream Hive has changed the property name used to specify > I think also HBase? Can we pull in the JIRA numbers in the corresponding pr Done http://gerrit.cloudera.org:8080/#/c/9124/1//COMMIT_MSG@10 PS1, Line 10: HBase table names. It is relatively straitforward to make > nit: straightforward Done http://gerrit.cloudera.org:8080/#/c/9124/1//COMMIT_MSG@14 PS1, Line 14: Testing: With an Impala built with a local override to use > The documentation in docs/topics/impala_hbase.xml refers "hbase.table.name" I think I can "magically" fix this. We're going to need the property name in an environment variable anyway because tests. This should do it: # Make the HBASE_TABLE_NAME available to tests and scripts export HBASE_TABLE_NAME_PROPERTY=\ `javap -constants org.apache.hadoop.hive.hbase.HBaseSerDe | grep HBASE_TABLE_NAME |\ sed 's/[^"]*"\([^"]*\).*/\1/'` http://gerrit.cloudera.org:8080/#/c/9124/1/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java File fe/src/main/java/org/apache/impala/catalog/HBaseTable.java: http://gerrit.cloudera.org:8080/#/c/9124/1/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java@450 PS1, Line 450: // the original table name, and if that fails, try looking for the > As Dimitris points out, this would be clearer if we said: Will use HBASE_TABLE_NAME_KEY -- To view, visit http://gerrit.cloudera.org:8080/9124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7c5b62f38be275762771ecf39cf898f06f8138b Gerrit-Change-Number: 9124 Gerrit-PatchSet: 1 Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-Comment-Date: Thu, 25 Jan 2018 00:00:56 +0000 Gerrit-HasComments: Yes
