Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9124 )
Change subject: IMPALA-6440: Backwards compatibility for HBase metadata ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9124/1/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java File fe/src/main/java/org/apache/impala/catalog/HBaseTable.java: http://gerrit.cloudera.org:8080/#/c/9124/1/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java@450 PS1, Line 450: // the original table name, and if that fails, try looking for the > As Dimitris points out, this would be clearer if we said: I can't do this. HBASE_TABLE_NAME is defined in a Hive class which is thoroughly wedged into its public API. I can only rename HBASE_TABLE_NAME_COMPAT - and since I can't rename the first, I'd prefer to follow the naming convention and omit the _KEY. I agree it is a better name though. -- To view, visit http://gerrit.cloudera.org:8080/9124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7c5b62f38be275762771ecf39cf898f06f8138b Gerrit-Change-Number: 9124 Gerrit-PatchSet: 1 Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-Comment-Date: Thu, 25 Jan 2018 20:36:00 +0000 Gerrit-HasComments: Yes
