Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 )
Change subject: IMPALA-6193: Track memory of incoming data streams ...................................................................... Patch Set 14: Code-Review+1 (5 comments) Tim may want to take another pass on the new patch given it changed a bit since he +1'ed it. http://gerrit.cloudera.org:8080/#/c/8914/14/be/src/rpc/rpc-mgr-test.cc File be/src/rpc/rpc-mgr-test.cc: http://gerrit.cloudera.org:8080/#/c/8914/14/be/src/rpc/rpc-mgr-test.cc@219 PS14, Line 219: nit: indent off http://gerrit.cloudera.org:8080/#/c/8914/14/be/src/rpc/rpc-mgr-test.cc@225 PS14, Line 225: nit: indent off http://gerrit.cloudera.org:8080/#/c/8914/14/be/src/rpc/rpc-mgr-test.cc@271 PS14, Line 271: nit: indent off http://gerrit.cloudera.org:8080/#/c/8914/14/be/src/rpc/rpc-mgr-test.cc@297 PS14, Line 297: nit: indent off http://gerrit.cloudera.org:8080/#/c/8914/14/be/src/runtime/krpc-data-stream-recvr.cc File be/src/runtime/krpc-data-stream-recvr.cc: http://gerrit.cloudera.org:8080/#/c/8914/14/be/src/runtime/krpc-data-stream-recvr.cc@458 PS14, Line 458: int64_t transfer_size = payload->rpc_context->GetTransferSize(); : Status::OK().ToProto(payload->response->mutable_status()); : payload->rpc_context->RespondSuccess(); : recvr_->mem_tracker()->Release(transfer_size); This pattern seems to occur quite a number of times. Do you think it's worth factoring it out as a function: void Respond(const Status& status) { int64_t transfer_size = payload->rpc_context->GetTransferSize(); status.ToProto(payload->response->mutable_status()); payload->rpc_context->RespondSuccess(); recvr_->mem_tracker()->Release(transfer_size); } -- To view, visit http://gerrit.cloudera.org:8080/8914 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2df1204d2483313a8a18e5e3be6cec9e402614c4 Gerrit-Change-Number: 8914 Gerrit-PatchSet: 14 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sun, 28 Jan 2018 00:48:36 +0000 Gerrit-HasComments: Yes
