Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 )
Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/8971/8/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/8971/8/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@95 PS8, Line 95: private static final long MIN_BLOOM_FILTER_SIZE = 4 * 1024; : private static final long MAX_BLOOM_FILTER_SIZE = 512 * 1024 * 1024; the query option restrictions already take care of this limit, by making sure that query options RUNTIME_FILTER_{MIN,MAX}_SIZE are in this range, Which would make it impossible to write a test case that exercises those hard limits here. Also, this makes the bounds applied below redundant. Should I still keep these in the constructor as a safeguard? or should i just put a precondition.check() instead? -- To view, visit http://gerrit.cloudera.org:8080/8971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea2759665fb2e8bef9433014a8d42a7ebf99ce1f Gerrit-Change-Number: 8971 Gerrit-PatchSet: 8 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 01 Feb 2018 21:35:26 +0000 Gerrit-HasComments: Yes
