Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 )
Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/8971/10/fe/src/main/java/org/apache/impala/planner/PlanFragment.java File fe/src/main/java/org/apache/impala/planner/PlanFragment.java: http://gerrit.cloudera.org:8080/#/c/8971/10/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@262 PS10, Line 262: .build() Shouldn't build be called last? http://gerrit.cloudera.org:8080/#/c/8971/10/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/8971/10/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@125 PS10, Line 125: ong maxLimit = BitUtil.roundUpToPowerOf2(tQueryOptions : .getRuntime_filter_max_size()); : long minBufferSize = BitUtil.roundUpToPowerOf2(BackendConfig.INSTANCE : .getMinBufferSize()); You're calling roundUpToPoweOf2 multiple times while you only need to do it once. I think it may be simpler to do: maxVal = BitUtil.roundUpToPowerOf2(Math.max(maxLimit, minBufferSize)); http://gerrit.cloudera.org:8080/#/c/8971/10/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@136 PS10, Line 136: // Make sure minVal <= defaultVal <= maxVal -- To view, visit http://gerrit.cloudera.org:8080/8971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea2759665fb2e8bef9433014a8d42a7ebf99ce1f Gerrit-Change-Number: 8971 Gerrit-PatchSet: 10 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 07 Feb 2018 19:20:58 +0000 Gerrit-HasComments: Yes
