Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8949 )
Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
......................................................................
Patch Set 8:
Looks like the API for Metric changed
-fsanitize=thread -DTHREAD_SANITIZER -fverbose-asm -D_GNU_SOURCE
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -fPIC
-fPIC -MD -MT be/src/service/CMakeFiles/Service.dir/impala-server.cc.o -MF
be/src/service/CMakeFiles/Service.dir/impala-server.cc.o.d -o
be/src/service/CMakeFiles/Service.dir/impala-server.cc.o -c
be/src/service/impala-server.cc
01:58:23 ] be/src/service/impala-server.cc:1325:36: error: no member named
'set_value' in 'impala::AtomicMetric<impala::TMetricKind::type::GAUGE>'; did
you mean 'SetValue'?
01:58:23 ] ImpaladMetrics::CATALOG_VERSION->set_value(catalog_version);
01:58:23 ] ^~~~~~~~~
01:58:23 ] SetValue
01:58:23 ] be/src/util/metrics.h:233:8: note: 'SetValue' declared here
01:58:23 ] void SetValue(const int64_t& value) { value_.Store(value); }
01:58:23 ] ^
01:58:23 ] be/src/service/impala-server.cc:1326:42: error: no member named
'set_value' in 'impala::AtomicMetric<impala::TMetricKind::type::GAUGE>'; did
you mean 'SetValue'?
01:58:23 ]
ImpaladMetrics::CATALOG_TOPIC_VERSION->set_value(catalog_topic_version);
01:58:23 ] ^~~~~~~~~
01:58:23 ] SetValue
01:58:23 ] be/src/util/metrics.h:233:8: note: 'SetValue' declared here
01:58:23 ] void SetValue(const int64_t& value) { value_.Store(value); }
01:58:23 ] ^
01:58:23 ] be/src/service/impala-server.cc:1327:39: error: no member named
'set_value' in 'impala::LockedMetric<std::basic_string<char>,
impala::TMetricKind::type::PROPERTY>'; did you mean 'SetValue'?
01:58:23 ]
ImpaladMetrics::CATALOG_SERVICE_ID->set_value(PrintId(catalog_service_id));
01:58:23 ] ^~~~~~~~~
01:58:23 ] SetValue
01:58:23 ] be/src/util/metrics.h:197:8: note: 'SetValue' declared here
01:58:23 ] void SetValue(const T& value) {
01:58:23 ] ^
01:58:23 ] 3 errors generated.
01:58:23 ] ninja: build stopped: subcommand failed.
01:58:23 ] Error in /home/ubuntu/Impala/bin/make_impala.sh at line 178:
${MAKE_CMD} ${MAKE_ARGS}
--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 8
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Feb 2018 22:00:34 +0000
Gerrit-HasComments: No
