Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9186 )

Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms 
and negotiation thread count in KRPC
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/9186/1/be/src/rpc/rpc-mgr.cc
File be/src/rpc/rpc-mgr.cc:

http://gerrit.cloudera.org:8080/#/c/9186/1/be/src/rpc/rpc-mgr.cc@70
PS1, Line 70: Number of threads to dedicate to process connection negotiations
Maximum number of threads dedicated to handling RPC connection negotiations


http://gerrit.cloudera.org:8080/#/c/9186/1/be/src/rpc/rpc-mgr.cc@84
PS1, Line 84:   
bld.set_rpc_negotiation_timeout_ms(FLAGS_rpc_negotiation_timeout_ms);
Does it make sense to also call bld.set_min_negotiation_threads(1) ?


http://gerrit.cloudera.org:8080/#/c/9186/1/be/src/rpc/rpc-mgr.cc@84
PS1, Line 84: FLAGS_rpc_negotiation_timeout_ms
What happens if this flag is set to negative by accident ? Will the code crash 
or does it translate to a very large unsigned value ?


http://gerrit.cloudera.org:8080/#/c/9186/1/be/src/rpc/rpc-mgr.cc@85
PS1, Line 85: FLAGS_rpc_negotiation_thread_count
Will it be safer to do max(1, FLAGS_rpc_negotiation_thread_count) to guarantee 
there is at least on negotiation thread available ?



--
To view, visit http://gerrit.cloudera.org:8080/9186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I108d700e7eac04b678e21a3a920aac81ba8eede5
Gerrit-Change-Number: 9186
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Feb 2018 21:43:52 +0000
Gerrit-HasComments: Yes

Reply via email to