Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9186 )
Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC ...................................................................... Patch Set 4: Code-Review+2 (2 comments) Thanks for the review. Holding off on GVO until IMPALA-6485 unblocks GVO. http://gerrit.cloudera.org:8080/#/c/9186/3/be/src/rpc/rpc-mgr-test.cc File be/src/rpc/rpc-mgr-test.cc: http://gerrit.cloudera.org:8080/#/c/9186/3/be/src/rpc/rpc-mgr-test.cc@235 PS3, Line 235: // establishment fails. > May help to clarify: Done http://gerrit.cloudera.org:8080/#/c/9186/3/be/src/rpc/rpc-mgr-test.cc@252 PS3, Line 252: secondary_rpc_mgr.Shutdown(); > nit: extra blank line. Done -- To view, visit http://gerrit.cloudera.org:8080/9186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I108d700e7eac04b678e21a3a920aac81ba8eede5 Gerrit-Change-Number: 9186 Gerrit-PatchSet: 4 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Tue, 06 Feb 2018 22:31:18 +0000 Gerrit-HasComments: Yes
