Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9186 )
Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/9186/2/be/src/rpc/rpc-mgr-test.cc File be/src/rpc/rpc-mgr-test.cc: http://gerrit.cloudera.org:8080/#/c/9186/2/be/src/rpc/rpc-mgr-test.cc@537 PS2, Line 537: > Should this use something like ScopedFlagSetter() in case the ASSERT below Yes, good idea. Done. http://gerrit.cloudera.org:8080/#/c/9186/2/be/src/rpc/rpc-mgr-test.cc@541 PS2, Line 541: > Is TLS always enabled ? Seem a bit misleading to have the "tls_" prefix her Sorry that was a mistake. I forgot to change the name of the variable. Done. http://gerrit.cloudera.org:8080/#/c/9186/2/be/src/rpc/rpc-mgr-test.cc@551 PS2, Line 551: > Just wondering if it'll be a problem if ASSERT() above gets triggered. Will If ASSERT() is triggered, we fail the BE test anyway right? So, even though the RpcMgr isn't shutdown, the process will kill it. -- To view, visit http://gerrit.cloudera.org:8080/9186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I108d700e7eac04b678e21a3a920aac81ba8eede5 Gerrit-Change-Number: 9186 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Tue, 06 Feb 2018 19:14:02 +0000 Gerrit-HasComments: Yes
