Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9191 )
Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9191/2/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/9191/2/shell/impala_shell.py@394 PS2, Line 394: line = line[0: line.index('--')].strip() if '--' in line else line > I don't think that this is sufficient to determine the location of a commen I changed the logic in my 3rd patch to use an SQL parser to remove the last comment token. -- To view, visit http://gerrit.cloudera.org:8080/9191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I54f9a8f65214023520eaa010fc462a663d02d258 Gerrit-Change-Number: 9191 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Fri, 02 Feb 2018 23:45:42 +0000 Gerrit-HasComments: Yes
