Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9191 )
Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9191/3/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/9191/3/shell/impala_shell.py@394 PS3, Line 394: statements = sqlparse.parse(line) I'm concerned that this is a fairly heavy-weight operation to do for every query. Have you done any performance tests to see how much time this takes, particularly with a large query (eg. something from tpcds)? Maybe sqlparse.format(line, strip_comments=True) would be work? I would expect it to be faster (you can check this) and it would also save you having to do the logic below where you check tokens. -- To view, visit http://gerrit.cloudera.org:8080/9191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I54f9a8f65214023520eaa010fc462a663d02d258 Gerrit-Change-Number: 9191 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Sat, 03 Feb 2018 00:50:15 +0000 Gerrit-HasComments: Yes
