Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9191 )
Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/9191/5/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/9191/5/tests/shell/test_shell_interactive.py@444 PS5, Line 444: queries = ['select 1 + 1; --comment', Additional tests: 1. Test where the last line contains part of the SQL statement, the delimiter, and a comment. This is to check that sqlparse can remove the comment from a line with an incomplete SQL statement. Example: select c from ( select count(*) from t ) v; -- Incomplete SQL statement in this line 2. Test multi-line comments Example: select c1 from t order by c2; /* * Multi-line comment */ -- To view, visit http://gerrit.cloudera.org:8080/9191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I54f9a8f65214023520eaa010fc462a663d02d258 Gerrit-Change-Number: 9191 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Tue, 13 Feb 2018 17:51:33 +0000 Gerrit-HasComments: Yes
