Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9123 )
Change subject: IMPALA-6437: separate AC/scheduler from catalog topic updates ...................................................................... Patch Set 13: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/9123/11/be/src/statestore/statestore.h File be/src/statestore/statestore.h: http://gerrit.cloudera.org:8080/#/c/9123/11/be/src/statestore/statestore.h@356 PS11, Line 356: GetSubscribedTopics > What about something like GetTopicsMapForId()? That seems to describe more works for me http://gerrit.cloudera.org:8080/#/c/9123/11/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: http://gerrit.cloudera.org:8080/#/c/9123/11/be/src/statestore/statestore.cc@651 PS11, Line 651: : LOG(INFO) << "Received request for different delta base of topic: " : << update.topic_name << " from: " << subscriber->id() : << " subscriber from_version: " << update.from_version; : subscriber->SetLastTopicVersionProcessed(topic_it->first, update.from_version); : } : : Topic& topic = topic_it->second; : v > I don't necessarily want to hold 'transient_entry_lock_' for the duration o Nevermind. I neglected the topic concurrency when thinking about it. -- To view, visit http://gerrit.cloudera.org:8080/9123 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc49c2d0f2a5bfad822545616b8c62b4b95dc210 Gerrit-Change-Number: 9123 Gerrit-PatchSet: 13 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 05 Feb 2018 20:28:06 +0000 Gerrit-HasComments: Yes
