Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9123 )
Change subject: IMPALA-6437: separate AC/scheduler from catalog topic updates ...................................................................... Patch Set 11: (1 comment) Carry +1 http://gerrit.cloudera.org:8080/#/c/9123/11/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: http://gerrit.cloudera.org:8080/#/c/9123/11/be/src/statestore/statestore.cc@651 PS11, Line 651: : vector<TopicEntry::Version> entry_versions = topic->Put(update.topic_entries); : if (!subscriber->AddTransientEntries( : update.topic_name, update.topic_entries, entry_versions)) { : // Subscriber was unregistered - clean up the transient entries. : for (int i = 0; i < update.topic_entries.size(); ++i) { : topic->DeleteIfVersionsMatch(entry_versions[i], update.topic_entries[i].key); : } : } > Nevermind. I neglected the topic concurrency when thinking about it. Added a comment. -- To view, visit http://gerrit.cloudera.org:8080/9123 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc49c2d0f2a5bfad822545616b8c62b4b95dc210 Gerrit-Change-Number: 9123 Gerrit-PatchSet: 11 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 06 Feb 2018 00:32:27 +0000 Gerrit-HasComments: Yes
