Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9123 )
Change subject: IMPALA-6437: separate AC/scheduler from catalog topic updates ...................................................................... Patch Set 14: Code-Review+1 This looks okay to me. I focused mostly on headers and only took a quick looks at implementation. Up to you whether you want to have another reviewer in addition to Tianyi take a deeper look at the code. -- To view, visit http://gerrit.cloudera.org:8080/9123 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc49c2d0f2a5bfad822545616b8c62b4b95dc210 Gerrit-Change-Number: 9123 Gerrit-PatchSet: 14 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 06 Feb 2018 18:54:25 +0000 Gerrit-HasComments: No