Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 )
Change subject: Force inlining of BloomFilter::MakeMask ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9214/2/be/src/util/bloom-filter.h File be/src/util/bloom-filter.h: http://gerrit.cloudera.org:8080/#/c/9214/2/be/src/util/bloom-filter.h@162 PS2, Line 162: __attribute__((__target__("avx2"))); Yes, I see it too in BucketFindAvx2 0.67 ? mov %rdi,%r12 ? 1.07 ? mov %esi,%ebx ? 0.56 ? mov %edx,%edi ? 1.32 ? shl $0x5,%rbx ? 0.72 ? sub $0x18,%rsp ? 1.73 ? ? callq impala::BloomFilter::MakeMask(unsigned int) Wondering if the multi-versioning attribute is still needed since MakeMask only called from BucketFindAVX2 and BucketInsertAVX2 which also have (__target__("avx2")). -- To view, visit http://gerrit.cloudera.org:8080/9214 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89282f6c315570bea5ad8a0f854cb6eea0592923 Gerrit-Change-Number: 9214 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Comment-Date: Tue, 06 Feb 2018 16:50:08 +0000 Gerrit-HasComments: Yes
