Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/9214 )
Change subject: Force inlining of BloomFilter::MakeMask
......................................................................
Patch Set 2:
The speedup was pretty significant on the benchmark.
On my system before:
With AVX2:
insert: Function iters/ms 10%ile 50%ile 90%ile
10%ile 50%ile 90%ile
(relative) (relative) (relative)
---------------------------------------------------------------------------------------------------------
ndv 10k fpp 10.0% 1.06e+05 1.06e+05 1.07e+05
1X 1X 1X
ndv 10k fpp 1.0% 1.05e+05 1.06e+05 1.07e+05
0.998X 0.999X 0.998X
ndv 10k fpp 0.1% 1.06e+05 1.06e+05 1.07e+05
0.999X 1X 1X
ndv 1000k fpp 10.0% 1.05e+05 1.06e+05 1.07e+05
0.993X 0.992X 0.994X
ndv 1000k fpp 1.0% 1.04e+05 1.05e+05 1.06e+05
0.986X 0.988X 0.986X
ndv 1000k fpp 0.1% 1.04e+05 1.05e+05 1.06e+05
0.986X 0.987X 0.986X
ndv 100000k fpp 10.0% 3.84e+04 4.04e+04 4.4e+04
0.364X 0.38X 0.41X
ndv 100000k fpp 1.0% 3.9e+04 4.11e+04 4.46e+04
0.369X 0.386X 0.416X
ndv 100000k fpp 0.1% 3.77e+04 3.85e+04 4.58e+04
0.357X 0.362X 0.426X
find: Function iters/ms 10%ile 50%ile 90%ile
10%ile 50%ile 90%ile
(relative) (relative) (relative)
---------------------------------------------------------------------------------------------------------
present ndv 10k fpp 10.0% 1.12e+05 1.12e+05 1.13e+05
1X 1X 1X
absent ndv 10k fpp 10.0% 1.11e+05 1.12e+05 1.13e+05
0.998X 0.998X 1X
present ndv 10k fpp 1.0% 1.12e+05 1.12e+05 1.13e+05
1X 0.998X 0.999X
absent ndv 10k fpp 1.0% 1.12e+05 1.12e+05 1.13e+05
0.999X 1X 0.998X
present ndv 10k fpp 0.1% 1.12e+05 1.13e+05 1.13e+05
1X 1X 1X
absent ndv 10k fpp 0.1% 1.12e+05 1.12e+05 1.13e+05
0.999X 0.999X 0.998X
present ndv 1000k fpp 10.0% 1.08e+05 1.09e+05 1.1e+05
0.967X 0.969X 0.967X
absent ndv 1000k fpp 10.0% 1.09e+05 1.09e+05 1.1e+05
0.973X 0.97X 0.973X
present ndv 1000k fpp 1.0% 1.07e+05 1.08e+05 1.09e+05
0.96X 0.96X 0.961X
absent ndv 1000k fpp 1.0% 1.08e+05 1.09e+05 1.1e+05
0.971X 0.971X 0.969X
present ndv 1000k fpp 0.1% 1.05e+05 1.05e+05 1.06e+05
0.937X 0.938X 0.937X
absent ndv 1000k fpp 0.1% 1.06e+05 1.07e+05 1.08e+05
0.951X 0.949X 0.95X
present ndv 100000k fpp 10.0% 3.97e+04 4.08e+04 4.63e+04
0.356X 0.363X 0.408X
absent ndv 100000k fpp 10.0% 3.94e+04 4.08e+04 4.23e+04
0.353X 0.363X 0.374X
present ndv 100000k fpp 1.0% 4.19e+04 5.11e+04 7.02e+04
0.375X 0.454X 0.62X
absent ndv 100000k fpp 1.0% 3.9e+04 4.09e+04 4.28e+04
0.35X 0.364X 0.377X
present ndv 100000k fpp 0.1% 3.94e+04 4.26e+04 6.5e+04
0.353X 0.379X 0.573X
absent ndv 100000k fpp 0.1% 3.67e+04 3.71e+04 3.82e+04
0.329X 0.33X 0.337X
union: Function iters/ms 10%ile 50%ile 90%ile
10%ile 50%ile 90%ile
(relative) (relative) (relative)
---------------------------------------------------------------------------------------------------------
ndv 10k fpp 10.0% 5.46e+05 5.51e+05 5.56e+05
1X 1X 1X
ndv 10k fpp 1.0% 5.46e+05 5.49e+05 5.54e+05
1X 0.996X 0.996X
ndv 10k fpp 0.1% 5.46e+05 5.51e+05 5.56e+05
1X 1X 1X
ndv 1000k fpp 10.0% 5.47e+05 5.51e+05 5.55e+05
1X 1X 0.998X
ndv 1000k fpp 1.0% 5.48e+05 5.54e+05 5.65e+05
1X 1.01X 1.02X
ndv 1000k fpp 0.1% 5.48e+05 5.51e+05 5.55e+05
1X 1X 0.998X
ndv 100000k fpp 10.0% 5.48e+05 5.54e+05 5.65e+05
1X 1.01X 1.02X
ndv 100000k fpp 1.0% 5.43e+05 5.51e+05 5.57e+05
0.994X 1X 1X
ndv 100000k fpp 0.1% 5.47e+05 5.52e+05 5.57e+05
1X 1X 1X
--
To view, visit http://gerrit.cloudera.org:8080/9214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89282f6c315570bea5ad8a0f854cb6eea0592923
Gerrit-Change-Number: 9214
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Mostafa Mokhtar <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Tue, 06 Feb 2018 20:05:43 +0000
Gerrit-HasComments: No
