Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 )
Change subject: Force inlining of BloomFilter::MakeMask ...................................................................... Patch Set 3: > On my system after: > > With AVX2: > > insert: Function iters/ms 10%ile 50%ile > 90%ile 10%ile 50%ile 90%ile > (relative) (relative) (relative) > --------------------------------------------------------------------------------------------------------- > ndv 10k fpp 10.0% 2.1e+05 2.11e+05 2.13e+05 > 1X 1X 1X > ndv 10k fpp 1.0% 2.16e+05 2.18e+05 2.19e+05 > 1.03X 1.03X 1.03X > ndv 10k fpp 0.1% 2.12e+05 2.14e+05 2.16e+05 > 1.01X 1.01X 1.01X > ndv 1000k fpp 10.0% 1.98e+05 1.99e+05 2.01e+05 > 0.943X 0.942X 0.945X > ndv 1000k fpp 1.0% 1.96e+05 1.98e+05 1.99e+05 > 0.935X 0.936X 0.937X > ndv 1000k fpp 0.1% 1.96e+05 1.97e+05 1.99e+05 > 0.935X 0.934X 0.936X > ndv 100000k fpp 10.0% 5.63e+04 5.8e+04 6.18e+04 > 0.269X 0.274X 0.291X > ndv 100000k fpp 1.0% 5.64e+04 5.84e+04 6.24e+04 > 0.269X 0.276X 0.293X > ndv 100000k fpp 0.1% 5.56e+04 5.75e+04 5.86e+04 > 0.265X 0.272X 0.275X > > find: Function iters/ms 10%ile 50%ile > 90%ile 10%ile 50%ile 90%ile > (relative) (relative) (relative) > --------------------------------------------------------------------------------------------------------- > present ndv 10k fpp 10.0% 1.97e+05 1.98e+05 > 1.99e+05 1X 1X 1X > absent ndv 10k fpp 10.0% 1.99e+05 2.01e+05 > 2.03e+05 1.01X 1.01X 1.02X > present ndv 10k fpp 1.0% 1.97e+05 1.98e+05 > 2e+05 1X 1X 1X > absent ndv 10k fpp 1.0% 2e+05 2.01e+05 > 2.03e+05 1.02X 1.02X 1.02X > present ndv 10k fpp 0.1% 1.97e+05 1.99e+05 > 2e+05 1X 1X 1X > absent ndv 10k fpp 0.1% 2e+05 2.02e+05 > 2.03e+05 1.02X 1.02X 1.02X > present ndv 1000k fpp 10.0% 1.75e+05 1.77e+05 > 1.78e+05 0.891X 0.893X 0.893X > absent ndv 1000k fpp 10.0% 1.78e+05 1.8e+05 > 1.81e+05 0.907X 0.907X 0.907X > present ndv 1000k fpp 1.0% 1.8e+05 1.82e+05 > 1.83e+05 0.917X 0.917X 0.919X > absent ndv 1000k fpp 1.0% 1.84e+05 1.86e+05 > 1.88e+05 0.937X 0.939X 0.941X > present ndv 1000k fpp 0.1% 1.69e+05 1.7e+05 > 1.71e+05 0.857X 0.859X 0.858X > absent ndv 1000k fpp 0.1% 1.7e+05 1.72e+05 > 1.74e+05 0.866X 0.87X 0.871X > present ndv 100000k fpp 10.0% 5.34e+04 5.53e+04 > 7.21e+04 0.271X 0.279X 0.362X > absent ndv 100000k fpp 10.0% 5.05e+04 5.28e+04 > 5.52e+04 0.257X 0.267X 0.277X > present ndv 100000k fpp 1.0% 5.43e+04 5.74e+04 > 8.65e+04 0.276X 0.29X 0.434X > absent ndv 100000k fpp 1.0% 5.09e+04 5.42e+04 > 5.73e+04 0.259X 0.274X 0.288X > present ndv 100000k fpp 0.1% 5.11e+04 5.24e+04 > 6.69e+04 0.26X 0.265X 0.336X > absent ndv 100000k fpp 0.1% 4.93e+04 5.02e+04 > 5.1e+04 0.251X 0.254X 0.256X > > union: Function iters/ms 10%ile 50%ile > 90%ile 10%ile 50%ile 90%ile > (relative) (relative) (relative) > --------------------------------------------------------------------------------------------------------- > ndv 10k fpp 10.0% 6.76e+05 6.8e+05 6.88e+05 > 1X 1X 1X > ndv 10k fpp 1.0% 6.77e+05 6.81e+05 6.87e+05 > 1X 1X 0.998X > ndv 10k fpp 0.1% 6.78e+05 6.82e+05 6.86e+05 > 1X 1X 0.996X > ndv 1000k fpp 10.0% 6.78e+05 6.82e+05 6.88e+05 > 1X 1X 1X > ndv 1000k fpp 1.0% 6.78e+05 6.83e+05 6.89e+05 > 1X 1X 1X > ndv 1000k fpp 0.1% 6.77e+05 6.8e+05 6.89e+05 > 1X 1X 1X > ndv 100000k fpp 10.0% 6.77e+05 6.81e+05 6.88e+05 > 1X 1X 0.999X > ndv 100000k fpp 1.0% 6.77e+05 6.85e+05 6.89e+05 > 1X 1.01X 1X > ndv 100000k fpp 0.1% 6.76e+05 6.8e+05 6.88e+05 > 1X 1X 1X Why did union speed up? In any case, +2, but I'd be curious about cat /sys/devices/system/cpu/intel_pstate/no_turbo cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor -- To view, visit http://gerrit.cloudera.org:8080/9214 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89282f6c315570bea5ad8a0f854cb6eea0592923 Gerrit-Change-Number: 9214 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 06 Feb 2018 20:15:14 +0000 Gerrit-HasComments: No
