anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9154 )
Change subject: IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/9154/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9154/2//COMMIT_MSG@12 PS2, Line 12: fails an > nit: fails and Done http://gerrit.cloudera.org:8080/#/c/9154/2/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/9154/2/be/src/codegen/llvm-codegen.cc@280 PS2, Line 280: return Status(diagnostic_err); > since the diagnostic handler is called, it would be worth adding the messag Done http://gerrit.cloudera.org:8080/#/c/9154/2/be/src/codegen/llvm-codegen.cc@1315 PS2, Line 1315: Status status = CreateFromFile(nullptr, &pool, nullptr, file, module_id, &codegen); : if (!status.ok()) { : codegen->Close(); : return status; : } > i hit the same problem earlier when I tried loading a lib generated from an Done -- To view, visit http://gerrit.cloudera.org:8080/9154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id060668802ca9c80367cdc0e8a823b968d549bbb Gerrit-Change-Number: 9154 Gerrit-PatchSet: 3 Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Sat, 10 Feb 2018 00:54:41 +0000 Gerrit-HasComments: Yes
