anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9154 )
Change subject: IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/9154/3/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/9154/3/be/src/codegen/llvm-codegen.cc@223 PS3, Line 223: > This function also has the same bad pattern of not closing 'codegen' on err Done http://gerrit.cloudera.org:8080/#/c/9154/3/be/src/codegen/llvm-codegen.cc@1315 PS3, Line 1315: // entry: > CreateFromFile() should really close the LlvmCodegen object on failure - it Done. Removed the check in GetSymbols and moved it to CreateFromFile http://gerrit.cloudera.org:8080/#/c/9154/3/tests/query_test/test_udfs.py File tests/query_test/test_udfs.py: http://gerrit.cloudera.org:8080/#/c/9154/3/tests/query_test/test_udfs.py@332 PS3, Line 332: # 1. too many arguments > The local and HDFS file creation will race if test_udf_errors() runs with i Done http://gerrit.cloudera.org:8080/#/c/9154/3/tests/query_test/test_udfs.py@338 PS3, Line 338: check_call > Use call() instead of check_call(), since we want to execute the next clean Done -- To view, visit http://gerrit.cloudera.org:8080/9154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id060668802ca9c80367cdc0e8a823b968d549bbb Gerrit-Change-Number: 9154 Gerrit-PatchSet: 5 Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Wed, 21 Feb 2018 08:50:24 +0000 Gerrit-HasComments: Yes
