anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9154 )
Change subject: IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/9154/5/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/9154/5/be/src/codegen/llvm-codegen.cc@220 PS5, Line 220: status = (*codegen)->Init(std::move(loaded_module)); > We should still need to close *codegen if this fails. I.e. I think we need Done http://gerrit.cloudera.org:8080/#/c/9154/5/be/src/codegen/llvm-codegen.cc@251 PS5, Line 251: module_name, &loaded_module); > Same comment applies here. Done -- To view, visit http://gerrit.cloudera.org:8080/9154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id060668802ca9c80367cdc0e8a823b968d549bbb Gerrit-Change-Number: 9154 Gerrit-PatchSet: 6 Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Feb 2018 04:54:50 +0000 Gerrit-HasComments: Yes
