Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9168 )
Change subject: IMPALA-5690: Part 1: Rename ostream operators for thrift types ...................................................................... Patch Set 9: > Patch Set 9: Code-Review+1 > > Fyi, its nice for reviewers if you don't submit changes at the same time as a > rebase - if you look at the diff between patch 8 and 9 here it contains a > bunch of unrelated stuff, which makes it hard to see what changes you > actually made. > > I usually submit the review with the changes I made and then immediately > rebase and submit again. Thanks for the tip. -- To view, visit http://gerrit.cloudera.org:8080/9168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c303997411237e988ef960157f781776f6fcb60 Gerrit-Change-Number: 9168 Gerrit-PatchSet: 9 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Fri, 16 Feb 2018 19:15:55 +0000 Gerrit-HasComments: No
