Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9168 )
Change subject: IMPALA-5690: Part 1: Rename ostream operators for thrift types ...................................................................... Patch Set 9: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/9168/9/be/src/util/debug-util.cc File be/src/util/debug-util.cc: http://gerrit.cloudera.org:8080/#/c/9168/9/be/src/util/debug-util.cc@56 PS9, Line 56: return it == _##T##_VALUES_TO_NAMES.end() ? std::to_string(value) : it->second; \ > Scanner fuzz test caught a bug here. Thrift doesn't check the value of the Does a JIRA need to be filed? -- To view, visit http://gerrit.cloudera.org:8080/9168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c303997411237e988ef960157f781776f6fcb60 Gerrit-Change-Number: 9168 Gerrit-PatchSet: 9 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Tue, 20 Feb 2018 19:29:14 +0000 Gerrit-HasComments: Yes
