Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9370 )
Change subject: IMPALA-6530: Track time spent opening HDFS file handles ...................................................................... Patch Set 2: (1 comment) I noticed something I should've caught first time around. http://gerrit.cloudera.org:8080/#/c/9370/2/be/src/runtime/io/scan-range.cc File be/src/runtime/io/scan-range.cc: http://gerrit.cloudera.org:8080/#/c/9370/2/be/src/runtime/io/scan-range.cc@474 PS2, Line 474: RETURN_IF_ERROR(io_mgr_->ReopenCachedHdfsFileHandle(fs_, file_string(), How concerned are we about this being included in read time and not in open time? I think we can live with it, but maybe while we're here we should add a metric or counter for "bad" file handles" so that it's observable if we have a lot of "bad" file handles? -- To view, visit http://gerrit.cloudera.org:8080/9370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia560af2d9b12f158e8811900a7b9d98f8e760858 Gerrit-Change-Number: 9370 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 21 Feb 2018 19:53:36 +0000 Gerrit-HasComments: Yes
