Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9370 )
Change subject: IMPALA-6530: Track time spent opening HDFS file handles ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9370/3/be/src/runtime/io/disk-io-mgr.h File be/src/runtime/io/disk-io-mgr.h: http://gerrit.cloudera.org:8080/#/c/9370/3/be/src/runtime/io/disk-io-mgr.h@362 PS3, Line 362: Status ReopenCachedHdfsFileHandle(const hdfsFS& fs, std::string* fname, int64_t mtime, > Probably worth copying the comment about 'reader' from GetCachedHdfsFileHan Fixed up comments for GetExclusiveHdfsFileHandle, GetCachedHdfsFileHandle, and ReopenCachedHdfsFileHandle to make them more consistent. -- To view, visit http://gerrit.cloudera.org:8080/9370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia560af2d9b12f158e8811900a7b9d98f8e760858 Gerrit-Change-Number: 9370 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 22 Feb 2018 22:27:21 +0000 Gerrit-HasComments: Yes
