Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9370 )
Change subject: IMPALA-6530: Track time spent opening HDFS file handles ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9370/1/be/src/runtime/io/scan-range.cc File be/src/runtime/io/scan-range.cc: http://gerrit.cloudera.org:8080/#/c/9370/1/be/src/runtime/io/scan-range.cc@418 PS1, Line 418: SCOPED_TIMER(&io_mgr_->read_timer_); > It feels a little wonky to me to have this start and stop for each chunk. W This makes sense. On S3, we split up IOs into 128KB chunks, so this becomes awkward. I changed this to introduce another layer of nesting and moved the SCOPED_TIMERs there. -- To view, visit http://gerrit.cloudera.org:8080/9370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia560af2d9b12f158e8811900a7b9d98f8e760858 Gerrit-Change-Number: 9370 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 21 Feb 2018 19:36:20 +0000 Gerrit-HasComments: Yes
