Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9368 )
Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables ...................................................................... Patch Set 4: Code-Review+1 The patch looks good to me. One thing we need to do for TPCDS and possibly TPCH is change some of the columns from DOUBLE to DECIMAL for Kudu. The expected results need to be updated as well. The expected results should be the same as for other storage types. It probably makes sense to do that in a separate patch. -- To view, visit http://gerrit.cloudera.org:8080/9368 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a9fe5acadc53ec198585d765a8cfb0abe56e199 Gerrit-Change-Number: 9368 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Wed, 21 Feb 2018 20:05:38 +0000 Gerrit-HasComments: No
