Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9368 )

Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9368/3/be/src/exec/kudu-util.cc
File be/src/exec/kudu-util.cc:

http://gerrit.cloudera.org:8080/#/c/9368/3/be/src/exec/kudu-util.cc@215
PS3, Line 215: return ColumnType::CreateDecimalType(
             :           type_attributes.precision(), type_attributes.scale());
> Since this no longer fits on one line, just follow what the formatter says,
I ran the formatter and updated the patch to use the suggested changes.



--
To view, visit http://gerrit.cloudera.org:8080/9368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a9fe5acadc53ec198585d765a8cfb0abe56e199
Gerrit-Change-Number: 9368
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Taras Bobrovytsky <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-Comment-Date: Wed, 21 Feb 2018 19:35:06 +0000
Gerrit-HasComments: Yes

Reply via email to