Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9368 )
Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/9368/3/be/src/exec/kudu-util.h File be/src/exec/kudu-util.h: http://gerrit.cloudera.org:8080/#/c/9368/3/be/src/exec/kudu-util.h@78 PS3, Line 78: 'type' that needs updating (param is 'col_type'). But also I think you should not say "the primitive type in" since the decimal case requires the column type. http://gerrit.cloudera.org:8080/#/c/9368/3/be/src/exec/kudu-util.h@85 PS3, Line 85: 'type' same -- To view, visit http://gerrit.cloudera.org:8080/9368 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a9fe5acadc53ec198585d765a8cfb0abe56e199 Gerrit-Change-Number: 9368 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Wed, 21 Feb 2018 23:39:39 +0000 Gerrit-HasComments: Yes
