Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 )
Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/9384/11/www/rpcz.tmpl File www/rpcz.tmpl: http://gerrit.cloudera.org:8080/#/c/9384/11/www/rpcz.tmpl@108 PS11, Line 108: Thr > Thrift RPC ? Done http://gerrit.cloudera.org:8080/#/c/9384/11/www/rpcz.tmpl@230 PS11, Line 230: : for (var i = 0; i < json["per_conn_metrics"].length; ++ > Does this rely on the order of the fields in the json document ? Seems a bi I tried changing the order of the JSON and it turns out that it does depend on the order of the JSON. To fix this, I made an explicit ordering of keys in the function. However, the tradeoff now is that we have to update this function everytime we add/remove fields. Also, we cannot do it like update_krpc_services(), since we have to use the DataTables API to update the table. -- To view, visit http://gerrit.cloudera.org:8080/9384 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84fea531e98d3e84fcc57bf7533655218bc91f4c Gerrit-Change-Number: 9384 Gerrit-PatchSet: 12 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Mon, 05 Mar 2018 19:33:52 +0000 Gerrit-HasComments: Yes
