Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 )
Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/9384/11/www/rpcz.tmpl File www/rpcz.tmpl: http://gerrit.cloudera.org:8080/#/c/9384/11/www/rpcz.tmpl@230 PS11, Line 230: : for (var i = 0; i < json["per_conn_metrics"].length; ++ > I tried changing the order of the JSON and it turns out that it does depend Not sure I understand the comment about why we need to update this function when we add/remove fields in the json output ? Isn't the point of doing conn_json[key] to prevent this need to update this function unless we change the table layout in which case it makes sense to update this function ? -- To view, visit http://gerrit.cloudera.org:8080/9384 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84fea531e98d3e84fcc57bf7533655218bc91f4c Gerrit-Change-Number: 9384 Gerrit-PatchSet: 12 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Tue, 06 Mar 2018 19:37:33 +0000 Gerrit-HasComments: Yes
