Donghui Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 )
Change subject: IMPALA-6610: Impala shell fetches the value of ldap_password_cmd incorrectly ...................................................................... Patch Set 3: (1 comment) Thank you Fredy, I have solved that problem. http://gerrit.cloudera.org:8080/#/c/9506/1/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/9506/1/shell/impala_shell.py@1539 PS1, Line 1539: if p.returncode != 0: > You should only strip the new line when there's no error. Move line: 1539 t Done -- To view, visit http://gerrit.cloudera.org:8080/9506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie570166aea62af223905b7f0124e9efb15a88ac7 Gerrit-Change-Number: 9506 Gerrit-PatchSet: 3 Gerrit-Owner: Donghui Xu <xu.dong...@zte.com.cn> Gerrit-Reviewer: Donghui Xu <xu.dong...@zte.com.cn> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Comment-Date: Wed, 07 Mar 2018 01:44:52 +0000 Gerrit-HasComments: Yes