Donghui Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 )
Change subject: IMPALA-6610: Impala shell fetches the value of ldap_password_cmd incorrectly ...................................................................... Patch Set 4: (2 comments) I have modified the commit message according to your opinion. http://gerrit.cloudera.org:8080/#/c/9506/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9506/3//COMMIT_MSG@9 PS3, Line 9: The value of LDAP password in Impala shell contains extra line break. > nit: "The value of LDAP password in Impala shell contains extra line break. Done http://gerrit.cloudera.org:8080/#/c/9506/3//COMMIT_MSG@11 PS3, Line 11: I fixed the issue by removing extraneous '\n' in the LDAP password. > nit: "I fixed the issue by removing extraneous '\n' in the LDAP password." Done -- To view, visit http://gerrit.cloudera.org:8080/9506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie570166aea62af223905b7f0124e9efb15a88ac7 Gerrit-Change-Number: 9506 Gerrit-PatchSet: 4 Gerrit-Owner: Donghui Xu <xu.dong...@zte.com.cn> Gerrit-Reviewer: Donghui Xu <xu.dong...@zte.com.cn> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Comment-Date: Thu, 08 Mar 2018 02:28:44 +0000 Gerrit-HasComments: Yes