Bikramjeet Vig has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9501 )

Change subject: IMPALA-6614: ClientRequestState should use HS2 TOperationState
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9501/3/be/src/service/client-request-state.cc
File be/src/service/client-request-state.cc:

http://gerrit.cloudera.org:8080/#/c/9501/3/be/src/service/client-request-state.cc@a880
PS3, Line 880:
should we check for is_cancelled_ instead to be more explicit and in sync with 
the method comments


http://gerrit.cloudera.org:8080/#/c/9501/3/be/src/service/client-request-state.cc@a884
PS3, Line 884:
maybe mark a cancelled event even if it was cancelled by the user explicitly.



--
To view, visit http://gerrit.cloudera.org:8080/9501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36287eaf8f1dac23c306b470f95f379dfdc6bb5b
Gerrit-Change-Number: 9501
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Mar 2018 03:17:32 +0000
Gerrit-HasComments: Yes

Reply via email to