Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9501 )
Change subject: IMPALA-6614: ClientRequestState should use HS2 TOperationState ...................................................................... Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/9501/3/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/9501/3/be/src/service/client-request-state.cc@a880 PS3, Line 880: > I think the code is conceptually doing the right thing. If we've reached a Thanks for the explanation http://gerrit.cloudera.org:8080/#/c/9501/3/be/src/service/client-request-state.cc@a884 PS3, Line 884: > I think that makes sense, but as stated in the commit message, I want this Makes sense -- To view, visit http://gerrit.cloudera.org:8080/9501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36287eaf8f1dac23c306b470f95f379dfdc6bb5b Gerrit-Change-Number: 9501 Gerrit-PatchSet: 4 Gerrit-Owner: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Thu, 08 Mar 2018 18:32:47 +0000 Gerrit-HasComments: Yes
