Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 )
Change subject: IMPALA-6576: Add metrics for data stream service memory usage ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/9562/3/be/src/service/data-stream-service.cc File be/src/service/data-stream-service.cc: http://gerrit.cloudera.org:8080/#/c/9562/3/be/src/service/data-stream-service.cc@58 PS3, Line 58: DataStreamService nit: The naming conventions for all the other metrics seems to be like this: "data-stream-service" Let's be consistent with that. http://gerrit.cloudera.org:8080/#/c/9562/3/be/src/util/memory-metrics.h File be/src/util/memory-metrics.h: http://gerrit.cloudera.org:8080/#/c/9562/3/be/src/util/memory-metrics.h@203 PS3, Line 203: static BufferPoolMetric* LIMIT; : static BufferPoolMetric* SYSTEM_ALLOCATED; : static BufferPoolMetric* RESERVED; : static BufferPoolMetric* UNUSED_RESERVATION_BYTES; : static BufferPoolMetric* NUM_FREE_BUFFERS; : static BufferPoolMetric* FREE_BUFFER_BYTES; : static BufferPoolMetric* CLEAN_PAGES_LIMIT; : static BufferPoolMetric* NUM_CLEAN_PAGES; : static BufferPoolMetric* CLEAN_PAGE_BYTES; Do we need to make the metrics for MemTrackerMetric, globally visible like this? http://gerrit.cloudera.org:8080/#/c/9562/2/tests/custom_cluster/test_krpc_metrics.py File tests/custom_cluster/test_krpc_metrics.py: http://gerrit.cloudera.org:8080/#/c/9562/2/tests/custom_cluster/test_krpc_metrics.py@93 PS2, Line 93: metric_name = 'rpc.impala.DataStreamService.rpcs_queue_overflow' : before = self.get_metric(metric_name) : assert before == 0 : : self.client.execute(self.TEST_QUERY) : after = self.get_metric(metric_name) : assert before < after How about making this a helper function? And then taking metric_name as a parameter? We'll be adding more metrics in the future, so having this helper function would be nice. The 'before' check may have to go though, since it may not be 0 for anything after the first query is run. -- To view, visit http://gerrit.cloudera.org:8080/9562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5033b8dfda0b23d4230535ba13c3e050a35d01a3 Gerrit-Change-Number: 9562 Gerrit-PatchSet: 3 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 09 Mar 2018 21:02:45 +0000 Gerrit-HasComments: Yes
