Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 )
Change subject: IMPALA-6576: Add metrics for data stream service memory usage ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/9562/2/be/src/util/memory-metrics.h File be/src/util/memory-metrics.h: http://gerrit.cloudera.org:8080/#/c/9562/2/be/src/util/memory-metrics.h@263 PS2, Line 263: > They both are owned transitively by the exec env singleton which lives unti What I am worried about is that some other code may start creating metrics for MemTrackers whose lifetime is only for a single query. I guess the comment in InitMetrics() should be sufficient for now. http://gerrit.cloudera.org:8080/#/c/9562/3/be/src/util/memory-metrics.cc File be/src/util/memory-metrics.cc: http://gerrit.cloudera.org:8080/#/c/9562/3/be/src/util/memory-metrics.cc@309 PS3, Line 309: MemTrackerMetricType::TOTAL, mem_tracker)); nit: indent 4 -- To view, visit http://gerrit.cloudera.org:8080/9562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5033b8dfda0b23d4230535ba13c3e050a35d01a3 Gerrit-Change-Number: 9562 Gerrit-PatchSet: 3 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sat, 10 Mar 2018 03:03:12 +0000 Gerrit-HasComments: Yes
