Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 )
Change subject: IMPALA-6576: Add metrics for data stream service memory usage ...................................................................... Patch Set 3: (1 comment) Thanks for the review Michael. How do you feel about renaming the DataStreamService metric to data-stream-service (see other comments from Sailesh and me). http://gerrit.cloudera.org:8080/#/c/9562/3/be/src/util/memory-metrics.cc File be/src/util/memory-metrics.cc: http://gerrit.cloudera.org:8080/#/c/9562/3/be/src/util/memory-metrics.cc@309 PS3, Line 309: MemTrackerMetricType::TOTAL, mem_tracker)); > nit: indent 4 Line 309 compared to 308? The statement starts in 307 and I think we usually only indent one level within a statement, even if it nests deeper. Please let me know if I misunderstood your intent. -- To view, visit http://gerrit.cloudera.org:8080/9562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5033b8dfda0b23d4230535ba13c3e050a35d01a3 Gerrit-Change-Number: 9562 Gerrit-PatchSet: 3 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 10 Mar 2018 06:03:43 +0000 Gerrit-HasComments: Yes
