Vuk Ercegovac has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9564 )

Change subject: IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9564/2/tests/metadata/test_recover_partitions.py
File tests/metadata/test_recover_partitions.py:

http://gerrit.cloudera.org:8080/#/c/9564/2/tests/metadata/test_recover_partitions.py@346
PS2, Line 346: partition value
nit: partition path
(the value is not encoded, right?)


http://gerrit.cloudera.org:8080/#/c/9564/2/tests/metadata/test_recover_partitions.py@356
PS2, Line 356:     # only produce a single partition.
nit: ... when adding a single partition.



--
To view, visit http://gerrit.cloudera.org:8080/9564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If45d78d095a5d3e85ebf61722566136d17825559
Gerrit-Change-Number: 9564
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Mar 2018 20:39:56 +0000
Gerrit-HasComments: Yes

Reply via email to